Forget about Newport. Caerleon - just north of Newport has Roman remains but I would put it well down my list of priorities.
I have been to St.Briavels & it is pleasant enough but certainly not worth going to see by car - let alone public transport.
I suggest you make a base in Cardiff for SE Wales. As well as seeing Cardiff Castle, National Museum of Wales, wandering around the shopping area which has modern malls as well as Victorian arcades - also head down to the Bay - which is 1 mile south of the city centre - frequent (every 15 minutes) by tram-train from Queen Street Station. Another priority should be Caerphilly Castle - also reached by frequent trains from Central & Queen Street stations.
Another Cardiff priority should be St.Fagans Castle & Museum of Welsh history - Cardiff Bus 32 hourly & it takes about 30 minutes from the city centre. Be warned - no buses on Sundays & last bus back is around 2.20pm - so best to get out early ready for opening at 10am as the site is vast. (If you wish to see Llandaff Cathedral on return journey - leave 32 bus where it goes under a railway bridge at Waungron Park and walk about 1 mile NE).
If you wish to see Castell Coch - you need Stagecoach bus 132 from Greyfriars Road to Tongwynlais (by Lewis Arms pub) - then a half mile walk up hill to the castle.
https://www.nationaltrust.org.uk/visit/wales/dyffryn-gardens is another place near Cardiff that is worth visiting. First Bus X2 is the service you need to St.Nicholas (the bus is going to Porthcawl). From St. Nicholas, it is 1 mile walk down a country lane. Halfway you will see sign for Tinkinswood Burial Chamber - about a 6 minute walk across fields.
Tintern Abbey is currently covered in scaffolding - as is *St.Fagans Castle. Even if the scaffolding is still up next summer, *it is still well worth visiting.
As mentioned above, Swansea is not worth visiting but the Gower peninsula west of the city has wonderful coastlines on the south and west sides. Rhosili at the south-western tip is gorgeous and can be reached by Adventure bus from Swansea bus station. In view of the fact that you are heading to Pembrokeshire, if time is limited - skip Swansea & Gower and just take a direct train from Cardiff to Tenby.
I would not bother with the Corris railway. The Vale of Rheidol line from Aberystwyth is lovely. Porthmadog has both the Ffestiniog and Welsh Highland narrow gauge steam railways. The Snowdon Mountain Railway to the summit of the highest mountain in Wales (& England) starts from Llanberis.
Note that some bus stops are served by several routes. If the bus you want is approaching - hold out your arm.
Note that you will pay more for accommodation from late July & through August - when the schools are closed - than when the schools are open.