Month in Spain and Portugal help with itinerary looking for feedback.

Barcelona (3N) - not enough time. You won't be able to do much on arrival day, so you only have 2 days to see a beautiful city with lots of sights and great day trips as well.
Madrid (4N) - that's a lot of time unless you really want to devote 1 or 2 full days to European painting at the very fine museums.
Malaga (3N) Not sure why you are so interested in Malaga.
Ronda (2N) without a car, you will spend all your time in Ronda. If you are planning to arrive late in the day and depart early in the day, that's fine.
Sevilla (3N) kind of light for a lovely city, especially if you want to day trip to Cordoba.

I haven't been to Portugal, but 4N in Lagos without a car seems like a lot. It does seem odd that you are spending more time in Lisbon and Porto than Barcelona.

Thanks for your input. The extra time in Lisbon, Porto and Madrid is to allow us to do some day trips. We could certainly add a day to Barcelona, take one from Malaga and add one to Seville. We were hinting of renting a car to get us from Malaga to Ronda to Seville as well as the time we are in Lagos. Do you need an internationalist nail drivers license to drive in Europe? We are Canadian.

Go to CAA & get an int’l permit, around $25, good for a year. It’s a translation of your drivers license which you must also carry. Malaga-Ronda-Granada can be done as daytrips from 1 base to reduce some hotel changes which only eats up precious time. I believe the same for Lisbon-Obidos and Porto-Coimbra. Right now you have 11 hotel changes in a month. That’s exhausting!

Having been to both countries, I would propose the following:
Fly to Barcelona- 5 nights (4 full days much better than just 2 in this enjoyable city)
Train to Madrid - 4 nights (more to see and do than just 3 world-class museums) + 1 night in Toledo (30 min trains daily) (or 5 Madrid w/day trip to Toledo only if don't wish another hotel - nighttime with fewer tourists is a treat)
Train to Granada - 2 nights
skip Malaga this time of year
Train to Ronda - 2 nights
Train to Seville - 4 nights + 1 night in Córdoba (or 5 Sevilla w/day trip)
Bus to Lagos Portugal - 2 nights in Lagos (1 day enough, especially this time of year)
Train to Lisbon - 4 nights
Obidos - 2 nights
Coimbra -2 nights
Porto - 4 nights (to have an easy visit at the end of your trip)
Fly home from Porto.

I like this intinerary. By staying longer in the bigger places we could see the city and still do some day trips. Thanks so much for your input and feedback.

The first three weeks of April will be school Easter holidays, so places will be busier. I was in Portugal (Algarve) early April this year and the weather was cold and wet compared to usual.

Barcelona ideally needs more than 3 nights, particularly as the first couple of days may be lost to jet lag. Malaga is one place that could be omitted at that time of year unless you have a particular reason for visiting.

Seville to Lagos by bus will take the best part of 6 hours door to door, so I wouldn’t bother visiting here for just one day (2 nights) as the previous poster has suggested, as it’s out of the way for such a short visit. It depends on what you want to see as to what you drop. I could easily spend 2 weeks in the Lagos area alone!

I would prefer 2 nights in Evora than 2 in Obidos, the latter of which can be seen in a couple of hours.

I think that fundamentally you have a very good travel itinerary. I also 100% agree with GoodmanTX's recommended revisions, as it will maximize your sightseeing time and minimize travel time.

Just want to add that we visited Malaga last September for 2 nights, and we loved it, and we wished we had a 3rd night. I think it's an underrated city. The city center is beautiful and clean; we visited the cathedral, the alcazaba, the castle, the Picasso museum, and we walked on the seaside promenade, had drinks outside and watched the sun set. There is a wonderful indoor market! There are also more art museums if you like art, but we had already spent a lot of time in the outstanding art museums in Madrid, so we were fine with only visiting the Picasso Museum. I don't know what the weather will be like when you are there but it was very pleasant in September. However, there were very few people on the beach so the beach/swim season seemed to be winding down. We weren't there for the beach so that was fine with us, but we enjoyed the coastal ambience.

Forgot to add that you need 5 or 6 nights in Barcelona.

I'm finally getting to Barcelona this December for the first time and I'm guessing 5 nights is necessary but I was just in Portugal. I enjoyed Tavira, 3 nights may be plenty for the Algarve (it was chilly in June also but weather is now completely unpredictable anywhere). Obidos is very cute but 1 night is more than enough, same for Coimbra.
BTW, Seville is wonderful.