I haven't been to Morrocco so can't comment on that. But I will say that with only 2 weeks, I don't think you have time to visit Morrocco. Spain is a huge country with lots to see, lots of history and culture, so I think you should spend your 2 weeks in Spain.
If you haven't already made your airline reservations, I recommend making open-jaw or multi-city reservations: fly into Madrid and out of Barcelona so you don't waste time backtracking.
If you don't mind changing hotels, I recommend spending one night in Toledo, instead of seeing it as a day trip. Toledo is very popular and very crowded with daytrippers and huge tour buses, so it's very crowded during the day. It is so much nicer at night when the daytrippers have left and the city is lit up. I really enjoyed our one-night stay in Toledo. If we had seen Toledo as a day trip, I think my opinion would be "what is all the fuss about?"
Three days is the minimum for Seville. Two days in Granada is good. I notice you don't have Cordoba on your itinerary. Cordoba is a lovely city with many important historical sites. There is the Mezquita, Alcazar gardens, Palacio de Viana, Roman Bridge, and more. If you can fit it in, I suggest spending one night in Cordoba. You could probably do this if you don't have to backtrack to Madrid at the end of your trip. Some people visit Cordoba as a day trip from Seville, but I think those people are shortchanging Cordoba, with its white-washed buildings, narrow lanes, patios, and flower pots.
Flying to Barcelona from Granada is the best way to get there, IMO.
Getting to Granada from Seville: If the high-speed train tracks to Granada are not finished, you can take the ALSA bus from Seville to Granada. We used them twice in Spain. They are clean, modern, comfortable and air-conditioned. Your other choice would be to take the train to Antequera, and then change to a bus to Granada.
You will be in Madrid and Andalucia at a perfect time of year, weather-wise. We were in Madrid and Andalucia from mid-September to very early October. Temps were primarily in the 80's except for Seville which was 90 - 95 in early October. On another trip we were in Barcelona in mid-October, and temps were perfect for sightseeing. Summer in Andalucia is very, very hot!