We will be driving from Zaragoza to San Sebastian. I'm looking for something interesting along the way. I saw there is a castle in Olite. Any other recommendations?
Take a look at the Monasterio de Veruela. The monastery is very beautiful, and it is also the home of the museum of the Borja D.O. wine. If you have good weather, you can visit the town of Trasmoz. There is a castle you can walk around, and it is famous for being the only town that has been excommunicated (and still is).
The Royal Palace/Castle in Olite is very impressive even though much is a reconstruction. Plan on spending 2-3 hours there if you climb all the towers.
For lesser sites that don’t take long to see, the Romanesque bridge in Puente la Reina, Artajona, Monastery of Iranzu, Church of Saint Mary of Eunate, and the Alto de Perdón overlook.
While I never made it there Ujué is supposedly nice. How many places to stop depends on how much time you have.
If you do make it to Trasmoz, parking in the main village is for residents only. There is a free lot at the entrance to the village beside the CV-930. When walking around the village look for the plaques for those voted witch of the year. Nearby (20 minutes drive) is Ágreda and the Monasterio de la Inmaculada Concepción (monjas Concepcionistas). In it is the crypt of María de Jesús de Ágreda, the Blue nun. She was supposedly capable of bi-location.
As an FYI, Olite is a restricted driving zone. There is free parking in front of Convento de San Francisco. A second free lot is at Calle Uer-3, 5, 31390 Olite, Navarra. There is street parking along P.º de Doña Leonor, 9A, 31390 Olite, Navarra, Spain
I went to Olite in 2016. As of that year, it felt like the back of beyond--a glorious, non-touristy experience. I found the castle worthwhile, and I am not a fan of castles. I will caution you, though, about arriving outside of standard meal hours (which are very late in Spain) and expecting to find food. In the words of Penelope Casas, a food writer, in Olite "you may starve, but you will not be bored."