How long are the lines?

There is no answer. The length of the lines depends on the day, time of day, temperature, whether it is rain, etc.,etc.,etc. Someplace like the Edinburgh castle is wide open so line to get in is short. Some of the exhibit rooms could have lines. Other areas none. Just have to go with the flow and the flow varies a lot.

Okay, thank you. I just don't want to jam too much into one day.
Do you know anything about the flexipass?

it's for a regular commuter journey is that what you want?

cost depends on the journey you select

https://www.scotrail.co.uk/tickets/commuter

No from what I understand there's something called a flexipass (10 trips on a smart card). I didn't know if it's like a prepaid card. That you pay for ten trips and put it on this card and don't have to get a ticket each time. When I went on to find out more, they wanted my destination, as if you could only go to one destination and back several times. It also says there's a discount with it. I just thought I'd buy the card and use it when I need to, at any station, at any time, and I don't know if that's allowed or not.

So, I'm just trying to understand more about the flexipass and how it works.

I was in Edinburgh in August in 2016 and swore I will never go again at that time!! It was too packed with people for me (Not to mention hotels were really expensive.) We didn't have choice on our trip but to go then, and I'm glad we did, and saw the amazing Tattoo, but I really would like to spend some time there during a less insane period.

We bought our Edinburgh Castle tickets in advance and did not have to wait to get in, even with the crowds.

Are you aware that August is when the whole world descends on Edinburgh for the Fringe Festival? That makes hotels very expensive and fills the place up. Good entertainment though - and some few perhaps less good though.... and traditionally some a bit quirky or strange....

The flexipass is a commuter ticket - for use only on a repetitive journey, same starting point, same destination (and v.v.). That's why you have to provide those places so it can compute the ticket. You cannot get on and off on the route. It is not suitable as a tourist pass.

Perfect! That's exactly what I wanted to know. So, it sounds like you need to buy each ticket separately. I was just hoping there was a card you could load them all onto, so you didn't have to do that (or do they somewhere else?)
I really appreciate the advice and information. I do realize this was the craziest time to come but have been waiting to do it since I was little and I thought the excitement of the summer would be great. I am going to the Military Tattoo and slowly making a circle around the phenomenal country.
Advice on driving, what's the best pubs, places not to miss and places that you don't necessarily need to see.?. Any and all advice is appreciated!
Thanks!

There can be long lines at The castle. If you are going to other locations, consider purchasing heritage pass. This is a skip the line feature which saves money.