I created a full trip report and posted it over on Fodor's. Not sure if it makes sense for me to copy and paste it all here or if you are interested, you can read it there as it's public:
https://www.fodors.com/community/europe/edinburgh-trip-report-1731672/#post17664882
We had a great 5 day trip and packed a lot in there.