Couple more comments...
The DB Site: https://int.bahn.de/en
You will have some bus connections to make for the journey to Eltz and back and elsewhere, perhaps, but the DB site will provide those connections... no need to hunt down bus schedules separately
Nuremberg: I failed to comment on the 2 night-stay. Won't you need at least 3 nights for two separate day trips from Nuremberg?
Rothenburg: I see no issue with visiting on a day trip from Nuremberg, at least not in October, when crowds have dwindled some, especially if you can do it on a weekday. As for seeing Rothenburg at night... you can expect sunset at about 6 pm in October, and there are trains leaving at 8 pm and as late as 10 pm that will get you back to Nuremberg. It would not be my choice to check out that morning and tote my bags to Rothenburg for another check-in, then another check-out the next morning, and then to have to return to Nuremberg for sightseeing there or a day trip to Regensburg... Sleeping in Rothenburg for me would just be sleeping, not sightseeing, and would only put me behind schedule-wise. Rothenburg is a small town that doesn't take long to see. You will probably have time that day to do a little something in Nuremberg before you leave. Trains from Nuremberg arrive there at 11:51, 12:51, and 13:51, etc.. If you're staying for the evening in Rothenburg until 20:00 or later, arriving even at 13:51 leaves you with a lot of time on your hands in this place.
German Rail Pass: This might be worth a look for some or all of your journeys, especially if there's a fall sale in effect, . But it does not provide free river cruising on the Rhine; it will give you a 20% cruise discount, but that same discount has always been available with any train ticket used to reach the town you board in. GRP flyer:
https://assets.static-bahn.de/dam/jcr:c0b25c61-bd5a-41ac-aea9-a56b909a88b5/German_Rail_Pass_2024.pdf
St Goar: I've stayed here on separate occasions as well as in Boppard. This much smaller town might also make for a good travel base. The ferry crossing there is very convenient for using the trains on the opposite riverbank for visiting Rüdesheim and/or Braubach (Marksburg Castle.) Also, there are a few nice hotels with excellent views overlooking the Rhine scenery there. Boppard has waterfront hotels too...