8 days in Munich, what makes sense for our itinerary?

What an amazing trip together!
I can help a little, not for clubbing :)
I would definitely not tour Dachau on your arrival day! It is emotionally overwhelming. You can use a local bus and do it on your own, there is excellent signage. A full half day, maybe morning and get there when it opens. I'd combine it with the Victuelmarkt and that incredible clock (find out when it "performs") later that day, with so many food choices in the vicinity.
I was going to Salzburg for the RS tour. It will be a very full day trip if you get an early start- tbe train was about 3 hours in one direction. Even if you aren't Sound of Music fans seeing the garden was amazing.
Travel is so personal. I was underwhelmed after hauling up the fortress steps. There's not much to see up there, except the views? It was definitely pretty, but not my highlight. The gorgeous old cemetery by the very oldest church was amazing- each gravesite a beautiful little garden...
Hopefully you'll get a lot more suggestions! Safe travels!

I really liked both the Residenz and Nymphenburg in Munich. What I liked about Nymphenburg were the grounds with all the "mini" castles scattered around (you know, in case one is out in the yard and has a castle emergency). Also, the main hall there is one of the prettiest rooms I've ever seen.

You might like walking through the Englisher Garden to the Chinesischer Turm and visiting the Beer Gardens there, since that is a "typical" Munich experience. The garden is also a good place to cool off on a hot day, and it is busy with people sunbathing (some nude), playing ball, and, of course, drinking beer.

We used public transportation or walked when we were in Munich and it wasn't too bad. YMMV. Maybe this site would be helpful: https://boredinmunich.com/munich-public-transport-guide/ I find the Citymapper app helpful, too.

I wouldn't do Dachau on an arrival day. You're physically exhausted and then you'll be mentally exhausted. We also loved Nymphenburg. We liked the Residenz a lot, but it does go on and on and on. . .

We typically use the self guided walking tours from the Rick Steves' guidebook, and the Munich one was excellent. It does take you past the historical churches.

Can't help you much with "clubbing" but the first time I was there with my sons, ages 20 and 22, and the second time with my daughters, aged 20, and they all loved going to the beer halls. We went to an Augustiner right by the Marienplatz and another one closer to the train station. We also liked the Haufbrauhaus.

Well, it's been a few years since i stayed around the Bahnhof, but it was never the best of destinations. The area around the hostel is going to be a bit rough. And the whole area around the station is a construction zone. But you're only about 5 minutes walk from one of Europe's major shopping areas. The whole section from Karlsplatz to the river is shopping, and mostly pedestrian only. Most of the tourist stuff is around Maximillianplatz, but you can find almost anything in those 2-3 km of stores.

I would have suggested you stay further north of the main city area, up around the University, because that's where you'll find the best inexpensive places, and the most people your age. That's where you'll find local night life, not tourist stuff. There are some clubs down along the water, across and south of the Deutsches Museum. The area south of the Deutsches Museum used to be good at night also, but it's been to long since I was out in that area.

I took some family through the Residence last summer and it was a trip highlight for them. And the Alte Pinokothek is one of my favorite art museums.

If you want to see more historical sights, a day trip to Nuremberg would probably be better than Salzburg. I like both, but if you've never been there Nuremberg is something you should see, and it's extremely easy to do. Just walk out of the train station and head up the hill to the castle and as long as you stay inside the old city walls you can't get lost.

I would plan on a beer garden visit after Dachau. You should see it, but it can leave you with some pretty strong emotions.

I agree with the advice NOT to go to Dachau on arrival day. Also, go to a bierhall after Dachau. The Hofbrauhaus is great, and there’s lots of history there. Wander through the various rooms. It’s massive.

As far as public transportation, look into the Deutschland Ticket. It covers all regional transportation to the places you mention, including all the metros in Munich, for €58 each. One way from the airport is already €16, so it pays for itself pretty fast. Download the DB Navigator for train info, and the MVV app for metro travel within Munich.

Agree with the comments and suggestions made so far. I'll add, do Rick's Walking Tour on Saturday. Its a good overview of Munich, takes you thourgh some of the shopping areas, and ss a great way to stretch your legs and walkoff some jet lag.

Be aware that you will probably only be able to drop your bags at your hotel until a 3 or 4 PM check-in. Prepare to spend time in your travel outfit or have accessable clothes for a quick, restroom change at the airport.

If you all still have the energy, a beer garden for drinks and dinner on Satruday evening is the way to go. Prost!

harder time navigating the public transportation for Munich

Get the https://www.mvv-muenchen.de/en/index.html/ on everyones phone. You do not need to have an active data plan to access tickets you have purchased. You do need data or wifi to make purchases and to do trip planning. Of course, one phone can cover the whole group for planning. Suggest everyone have thier own ticket.

Also download the https://int.bahn.de/en/ for your trips to Nurnberg, Salzburg, etc. Like MVV, online to search and purchase. Offline to present your ticket if asked.

Before you go, use Google Maps and the two apps (above) to plan your trips around Munich and to other cities.

As suggested, consider the D-Ticket. Based upon your plans it will be the least expensive way to travel. It covers local trains (not IC or ICE) and all public transport (bus, tram, metro) in Germany. It is valid to Salzburg, but not for public transport in Salzburg, which you really don't need in relatively compact and walkable Salzburg. Search this forum for more on the D-Ticket. Lots of threads.

Have a great trip. I leave for Germany on Tuesday!!!

Summer train works are happening so be prepared for double the travel time and delays and there is work on the S8 lines as well. Munich public transport is great but in the summer be prepared for delays and no strong AC.

Two Munich tours I loved from Radius Tours was the Munich city center tour and the Beer and Brewery tour at night where you go to a couple beerhalls and get classic Bavarian food and try the beer on tap. Our American guide was amazing and I'm sorry I forgot her name-she is blond and from Oregon.

I'm way past my clubbing days but if you go on a walking tour or ask your hotel front desk, they may know more of the fashionable clubs.

My tips for Salzburg-stay overnight, go to the fortress and see the museum there. Go to the Mirabell Gardens-you'll recognize it from the Sound of Music "Doe-A-Deer" song. And if nice, do what the locals do and hang out on the grassy riverbank. I also enjoyed Mozart's Birthplace more than I thought I would though it gets crazy crowded. And for great pastries/cakes I can recommend Schatz Konditorei. They have the loveliest cakes and there is a good mixture of tourists and local workers. When I was there many workers came in for a slice of cake to go.

Thanks everyone! So it looks like the hotel is a bad idea? Our stay is still refundable but are there better recommendations that are walking distance from the Euro Youth Hostel? Or a hotel that is better but roughly the same distance from the train station, then the whole group can just meet at the station each day?

We definitely won't do Dachau on our first day and i'll do some more research on which of Nuremberg/Salzburg that will be cut out.
Updated itinerary
Saturday: Arrivals, possibly Rick's walking tour in the evening

Sunday: Dachau with beer garden and light shopping in the evening

Monday - Saturday, Munich sightseeing/half day at Moosburg and one of Nuremberg/Salzburg.

This group has been so helpful, thank you!

Sunday: Dachau with beer garden and light shopping in the evening

German shops are closed on Sunday.

We stayed about 3 blocks from your apartments this summer with 3 teenagers. We were never out past 10 and never felt unsafe. There are a couple beer gardens within walking distance. The Lowenbrau, where the food we ordered was excellent. And then we also went to Augustiner-Keller multiple times. It was large and had just a great ambience. Hirschgarten and Chinese Garden were also great, but we hit those when we were out in the area, not as a final kick-back before heading to our apartment. We also went to Hofbrauhaus. I would never discourage anyone from going there. But the outdoor area didn't have the same appeal as the others, in my opinion.

Going to Moosburg another option is to go further down the River Isar to Landshut and see the City Center and Castle above
20km from Moosburg

https://www.burg-trausnitz.de/englisch/tourist/index.htm

and a nice report about a daytrip to Landshut from Munich

Btw the train RE 3 from Munich Central train station towards Passau stops first in Moosburg and then Landshut (45 min from Munich)
Its 10min from Moosburg to Landshut with this train

Check Bahn(Railways) website for connection on day you travel