I'm a little confused about the Vorteilscard, it seems this is available for tourists? I'm aiming for the senior version. Would I save anything by having it? I've read that in some countries this type of card only gives a discount off the full price fare so, not much true savings. It looks like I'll only be making a Vienna-Salzburg trip, perhaps one to Melk, and then a Bavaria card to Munich.
The Vorteilscard discount always refers to the full fare. To obtain and pay for it does not make sense for just a few trips. Better to look for bargain offers, aka Sparschiene.
For Vienna to Salzburg, you also have the option of using the Westbahn trains. 33.50 EUR Flexpreis fares or WESTsuperpreis (advance purchase train specific nonrefundable) tickets for 13.99 EUR.
yeah, that guy in seat 61 seems to prefer the Westbahn trains. And since it's just one trip with two people, I'm not going to worry that much. OTOH, the Bayern-Ticket from Salzburg to Munich seems like a sweet deal.
My recollection is that Westbahn also had a senior discount ticket on the Salzburg-Vienna run -- tickets at the tobacco shop ?? Great train for rolling your luggage aboard.
Doesn't make sense for your travel.
For Vienna Salzburg look here as there are discount fares on Westbahn for people 60 and above - https://westbahn.at/en/offers/westbahn-offers/westaktivpreis/
For Vienna to Melk, buy the Einfach Raus ticket - https://www.oebb.at/en/tickets-kundenkarten/schueler-gruppen/einfach-raus-ticket
For Salzburg to Munich, the Bayern ticket.
All of these can be purchased on the day of travel.